-
Notifications
You must be signed in to change notification settings - Fork 875
fix(directives): set copy directive z-index below nav #769
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -25,7 +25,7 @@ angularIO.directive('copyContainer', function() { | |||
transclude: true, | |||
template: | |||
'<div style="position: relative">' + | |||
'<copy-button style="position: absolute; top: 10px; right: 0px; z-index: 1000" ></copy-button>' + | |||
'<copy-button style="position: absolute; top: 10px; right: 0px; z-index: 4" ></copy-button>' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not enough. Actually, there’s no reason for the z-index to be larger than 1, so you should set it to this exact value.
@Kevin-K Unfortunately, setting the There doesn’t seem to be any reason why |
Good catch, I didn't consider the side-nav z-indexes. Moved it to |
Fixes: #768
Sets the z:index on the copy-button directive to 4 to be lower than the main navbar.