Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

fix(directives): set copy directive z-index below nav #769

Closed
wants to merge 2 commits into from
Closed

fix(directives): set copy directive z-index below nav #769

wants to merge 2 commits into from

Conversation

Kevin-K
Copy link
Contributor

@Kevin-K Kevin-K commented Jan 28, 2016

Fixes: #768

Sets the z:index on the copy-button directive to 4 to be lower than the main navbar.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Kevin-K
Copy link
Contributor Author

Kevin-K commented Jan 28, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@@ -25,7 +25,7 @@ angularIO.directive('copyContainer', function() {
transclude: true,
template:
'<div style="position: relative">' +
'<copy-button style="position: absolute; top: 10px; right: 0px; z-index: 1000" ></copy-button>' +
'<copy-button style="position: absolute; top: 10px; right: 0px; z-index: 4" ></copy-button>' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not enough. Actually, there’s no reason for the z-index to be larger than 1, so you should set it to this exact value.

@christianliebel
Copy link
Contributor

@Kevin-K Unfortunately, setting the z-index to 4 is not enough, because you miss the nav bar in smartphone mode:

There doesn’t seem to be any reason why z-index should be larger than 1. Therefore I suggest that you update your PR and set z-index: 1. This fixes copy-button.

@Kevin-K
Copy link
Contributor Author

Kevin-K commented Mar 2, 2016

Good catch, I didn't consider the side-nav z-indexes.

Moved it to z-index: 1. While reading the tutorials I didn't notice anywhere where the copy button sits over any layered content. If it does and I missed it, setting up to z-index: 3 will remain under the side-nav when pushed to the xs layout.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants