Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(structural-directives): move ng-container section later in page #3367

Merged
merged 2 commits into from
Mar 11, 2017

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 10, 2017

This is a follow-up to #3345 (comment).

  • No changes were done to the <ng-container> section prose.
  • At the end of the template section I linked the "write your own structural directive" text to the "unless" directive section (because now there is <ng-container> in between the two).

@wardbell: @kapunahelewong and I discussed the section relocation, and she agrees with the change -- other edits to this guide, if any, will come in follow-up PRs.

This is a follow-up to
angular#3345 (comment).

No changes were done to the `<ng-container>` section prose.

@wardbell: @kapunahelewong and I discussed this, and she agrees with
the change -- other edits will come in another PR.
@chalin chalin requested a review from wardbell March 10, 2017 16:25
Oups, it seems I missed to back propagate some copyedits. Here they are.
@chalin
Copy link
Contributor Author

chalin commented Mar 10, 2017

Oups, it seems that I omitted to back propagate some copyedits. They've been added in the separate "post review" commit.

@wardbell
Copy link
Contributor

This will do for now. I'll be revisiting shortly for v.4 to cope with changes to the microsyntax and the move to <ng-template> whose implications I have not yet thought through.

@wardbell wardbell merged commit 9386a66 into angular:master Mar 11, 2017
@wardbell wardbell deleted the chalin-struct-dir-0310 branch March 11, 2017 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants