chore: remove moduleId from examples #3362
Conversation
| @@ -21,7 +21,6 @@ export class SomeAbsoluteComponent { | |||
| // #docregion relative-config | |||
| @Component({ | |||
| // #docregion module-id | |||
There was a problem hiding this comment.
Why is this #docregion still here?
There was a problem hiding this comment.
as a reminder that something is talking about moduleid and needs my revision.
There was a problem hiding this comment.
Ah ... and we are deleting this cookbook anyway.
| @@ -9,7 +9,6 @@ import { HeroService } from './hero.service'; | |||
| // #docregion renaming, metadata | |||
| @Component({ | |||
| // #enddocregion renaming | |||
There was a problem hiding this comment.
I think you can remove this
// #enddocregion renaming
// #docregion renaming
There was a problem hiding this comment.
Sure, saw that, forgot to make a note.
| @@ -5,6 +5,12 @@ block includes | |||
| The Angular documentation is a living document with continuous improvements. | |||
| This log calls attention to recent significant changes. | |||
|
|
|||
| ## Component relative paths cookbook has been deleted (2017-03-13) | |||
| The cookbook was well versed into moduleId, but there is no more moduleId in the guides. | |||
There was a problem hiding this comment.
I think we can combine lines 8 - 13 as
All mention of moduleId removed. "Component relative paths" cookbook deleted (2017-03-13)
We added a new SystemJS plugin (
systemjs-angular-loader.js) to our recommended SystemJS configuration. This plugin dynamically converts "component-relative" paths intemplateUrlandstyleUrlsto "absolute paths" for you.We strongly encourage you to only write component-relative paths. That is the only form of URL discussed in these docs. You no longer need to write
@Component({ moduleId: module.id }), nor should you.
| @@ -255,8 +255,6 @@ block ts-decorator | |||
| Here are a few of the possible `@Component` configuration options: | |||
There was a problem hiding this comment.
Here are a few of the most useful
@Componentconfiguration options:
| @@ -1679,10 +1679,6 @@ a(href="#toc") Back to top | |||
| :marked | |||
| **Do** name the style file `[component-name].component.css`, where [component-name] is the component name. | |||
|
|
|||
| .s-rule.do | |||
There was a problem hiding this comment.
I think we still need SOME of this:
.s-rule.do
:marked
**Do** specify _component-relative_ URLs, prefixed with `./`,
Just get rid of the moduleId stuff
I also removed some reactive forms live examples that got stuck in the repo, caught it sweeping moduleId.