docs(attribute-directives): copyedits + fix e2e warning #3330
Conversation
| @@ -39,7 +28,14 @@ export class HighlightDirective { | |||
| private highlight(color: string) { | |||
| this.el.nativeElement.style.backgroundColor = color; | |||
| } | |||
| // #enddocregion mouse-methods | |||
| // #enddocregion mouse-methods, | |||
There was a problem hiding this comment.
Why the move? Linter complains when properties follow methods. I hate that particular "rule" (what's the point?) and often disable it for a particular file but I don't see you doing that here.
There was a problem hiding this comment.
The file starts with
/* tslint:disable:no-unused-variable member-ordering */
and so the linter is happy (i.e., the build is green).
The move was so as to put all the extra "snippets" (not actually meant to be part of the class's default docregion), at the end.
(Btw, those two members were already "out of order". I figured that if they are going to be out-of-order, then might as well be at the end of the real class members.)
| @@ -1,5 +1,4 @@ | |||
| <!-- #docregion --> | |||
| <!-- #docregion v2 --> | |||
| <!-- #docregion v2, --> | |||
There was a problem hiding this comment.
I know that you can combine named and the unnamed region in a single line like this. I'm not sure that it helps the reader. Those trailing commas are hard to pick up. But let's forge ahead with this change.
There was a problem hiding this comment.
Ok, I'll refrain from combining them in the future (I just find excessive docregion lines distracting when trying to read the source).
|
@wardbell - pls see my line comments. Anything else to be done? |
- Prose: copyedits, including fix to misnamed directive class (`MyHighlightDirective` --> `HighlightDirective`). - E2E update to avoid warning of multiple matching elements. - Code: remove obsolete template region. - Remove obsolete Jade blocks (no longer required by Dart). - Replace old Jade syntax with plain markdown. - Remove a few unnecessary `:marked`.
chalin
force-pushed
the
chalin-attribute-directives-0301
branch
from
848c84c to
d319c4f
Compare
MyHighlightDirective-->HighlightDirective).:marked.