docs(attribute-directives): copy tweaks #3284
Conversation
|
|
||
| *Components* are the most common of the three directives. | ||
| You saw a component for the first time in the [QuickStart](../quickstart.html) example. | ||
| You saw a component for the first time in the [QuickStart](../quickstart.html) guide. |
There was a problem hiding this comment.
I thought that we were to use the term "page" instead of "guide" (although, in this case, the original "example" seems to be ok too).
There was a problem hiding this comment.
Do as you will in Dart land. We're doing differently here.
There was a problem hiding this comment.
Okey dokey. I just thought it was a TS land convention as well, but apparently no longer.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
| @@ -61,17 +61,17 @@ a#write-directive | |||
| :marked | |||
| Read more about [style binding](template-syntax.html#style-binding) on the [Template Syntax](template-syntax.html) page. | |||
|
|
|||
| For a simple example, though, this will demonstrate how attribute directives work. | |||
| For a simple example, though, this demonstrates how attribute directives work. | |||
There was a problem hiding this comment.
This aside about style binding is a mistake. FIrst, you couldn't use the style binding to set the background when the user hovers. Second, more importantly, this aside is distraction.
In a related PR I delete this aside and replace it with a one line example of how the new directive WILL apply to an element. I'll fix the resulting merge conflict.
|
|
||
| *Components* are the most common of the three directives. | ||
| You saw a component for the first time in the [QuickStart](../quickstart.html) example. | ||
| You saw a component for the first time in the [QuickStart](../quickstart.html) guide. |
There was a problem hiding this comment.
Do as you will in Dart land. We're doing differently here.
|
|
||
|
|
||
|
|
||
| :marked | ||
| ### Write the directive code | ||
| Follow the [setup](setup.html) instructions for creating a new project | ||
| Follow the [setup](setup.html) instructions for creating a new local project |
There was a problem hiding this comment.
I'm not against it entirely. But I don't see that the word "local" helps. If you agree, let's revert. If you don't, leave it.
Cleaning up a few copy details.