This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Update dependency-injection.jade #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: Dependency Injection "Here's our AppModule where we register a `Logger`, a `UserService`, and an `APP_CONFIG` provider." No Logger appears to be registered in the source code.
|
True. For some reason, the logger registration was moved to the |
|
Thanks, Ward, and BTW, always love your threads.
…-Josh
On Mon, Feb 6, 2017 at 7:02 PM, Ward Bell ***@***.***> wrote:
True. For some reason, the logger registration was moved to the
AppComponent. Thanks for finding.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3206 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvFd1Uz2sdBg7H0iMEyEP96bACnmaNqks5rZ97JgaJpZM4L4tg4>
.
|
abdel-ships-it
pushed a commit
to abdel-ships-it/angular.io
that referenced
this pull request
Feb 11, 2017
…ar#3206) "Here's our AppModule where we register a `Logger`, a `UserService`, and an `APP_CONFIG` provider." No Logger appears to be registered in the source code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: Dependency Injection
"Here's our AppModule where we register a
Logger, aUserService, and anAPP_CONFIGprovider." No Logger appears to be registered in the source code.