Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(deployment): fix broken deployment nav link and ordering #3156

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

tmeneau
Copy link
Contributor

@tmeneau tmeneau commented Jan 27, 2017

This pull request fixes an issue with the recent deployment guide docs (pull request #3043).

The changes to the relevant _data.json referenced production-deploy, while the jade template was named deployment. This pull request also updates the alphabetic ordering for the deployment guide in the navigation sidebar to reflect the "Deployment" title.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tmeneau
Copy link
Contributor Author

tmeneau commented Jan 27, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@filipesilva
Copy link
Contributor

Nice, thanks for the fix!

@filipesilva filipesilva merged commit 8728e49 into angular:master Jan 30, 2017
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants