docs(forms): copyedits #3149
docs(forms): copyedits #3149
Conversation
- Removed side note detailing ngModel; now referring reader to template-syntax page instead.
There was a problem hiding this comment.
I didn't check these changes carefully, but they seem reasonable. (I don't remember which changes came from who, but I was surprised that improvements we had in the Dart version weren't already in this version.)
@kapunahelewong could you do a more thorough review?
|
|
||
| :marked | ||
| It's an anemic model with few requirements and no behavior. Perfect for our demo. | ||
|
|
||
| The TypeScript compiler generates a public field for each `public` constructor parameter and | ||
| assigns the parameter’s value to that field automatically when we create new heroes. | ||
|
|
||
| The `alterEgo` is optional and the constructor lets us omit it; note the (?) in `alterEgo?`. | ||
| The `alterEgo` is optional, so the constructor will let us omit it; note the (?) in `alterEgo?`. |
There was a problem hiding this comment.
will let -> lets
(not a big deal, but strange that it's worse)
| - display validation errors to users and enable/disable form controls | ||
|
|
||
| - use [template reference variables](./template-syntax.html#ref-vars) for sharing information among HTML elements | ||
| - Build an Angular form with a component and template |
There was a problem hiding this comment.
According to the guidelines, we're supposed to put a period at the end of each list item, however, I have seen that not applied to TOCs, which I consider this to be. However, you'd be within the guidelines by having periods on each since it isn't labeled explicitly as a TOC. I'd probably put them but considering the context, it's arguable not to have them.
| 1. Add custom CSS to provide visual feedback. | ||
| 1. Show and hide validation error messages. | ||
| 1. Handle form submission with **ngSubmit**. | ||
| 1. Disable the form’s submit button until the form is valid. |
There was a problem hiding this comment.
Ah, I see you know what I said in my first comment.
* - Copyedits, some from Kathy (from an early revision of the forms page). - Removed side note detailing ngModel; now referring reader to template-syntax page instead. * post-review edits
Copyedits from syncing with Dart version of page.
:marked.ngModel; we're now referring reader tongModeltemplate syntax section instead.cc @kwalrath @kapunahelewong