Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(webpack): update to webpack 2 #3108

Merged
merged 2 commits into from
Jan 22, 2017
Merged

Conversation

Foxandxss
Copy link
Member

No description provided.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@wardbell
Copy link
Contributor

wardbell commented Jan 21, 2017

I found one grammar mistake. As I fixed it, I decided to convert to the Google doc guidelines (a lot of "we" to "you"). I touched up a few things while at it. All of my changes are in a separate commit for comparison.

Would you mind giving a swift read to make sure it's still good. Then we can merge (feel free to merge it yourself as I am done with my review).

@Foxandxss Foxandxss merged commit 9fb5e0a into angular:master Jan 22, 2017
@Foxandxss Foxandxss deleted the webpack-update branch January 22, 2017 11:51
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
* docs(webpack): update to webpack 2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants