Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(architecture): update wording #3049

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

jvandemo
Copy link
Contributor

This PR updates the wording so it aligns with the actual code that is displayed under the wording.

Before:
Here's a HeroService that fetches heroes and returns them in a resolved Promise.

After:
Here's a HeroService that uses a Promise to fetch heroes.

Code:

getHeroes() {
  this.backend.getAll(Hero).then( (heroes: Hero[]) => {
    this.logger.log(`Fetched ${heroes.length} heroes.`);
    this.heroes.push(...heroes); // fill cache
  });
  return this.heroes;
}

The code does not return a promise so I believe the new wording is more accurate.

@wardbell wardbell merged commit 6b8cfc1 into angular:master Jan 2, 2017
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants