This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(examples): don't gitignore _examples/tsconfig.json #2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak to `.gitignore` so that only the `tsconfig.json` files in subdirectories are ignored, not the one directly in this `_examples` folder. Also, add a package.json script definition for `http-server` for more convenient access (w/o invoking tsc as is forced in the script definition given in `_boilerplate/package.json`.
filipesilva
approved these changes
Dec 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak to
.gitignoreso that only thetsconfig.jsonfiles in subdirectories are ignored, not the one directly in this_examplesfolder.Also, add a package.json script definition for
http-serverfor more convenient access (w/o invoking tsc as is forced in the script definition given in_boilerplate/package.json.cc @kwalrath