-
Notifications
You must be signed in to change notification settings - Fork 875
docs(webpack): fix for tsconfig.json provided in example #2892
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLAs look good, thanks! |
I signed it! |
We don't need |
Hello @Foxandxss ,
Sorry. for this. Best regards, |
Sure you can. The node_modules exclusion is only needed if you specify the files by hand, since we do not, node_modules is excluded automagically. |
@Foxandxss, Best regards, |
@@ -6,8 +6,9 @@ | |||
"sourceMap": true, | |||
"emitDecoratorMetadata": true, | |||
"experimentalDecorators": true, | |||
"lib": ["es2015", "dom"], | |||
"removeComments": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please remove this removeComments
setting too. That is the default setting and we don't want it here. I thought I'd removed it everywhere but I guess I missed this one.
Then I can merge your PR.
Hello @wardbell , I've just removed Best regards, |
Thank you. |
Pull request for this issue.