This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: use common instructions for popping out plunker window #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
changed the title
To see the browser title or address bar changes. Instructions are a little more complicated when the plunker is in embedded style
wardbell
force-pushed
the
chore-set-addr-bar
branch
from
470e01e to
0986dce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the browser title or address bar changes. Instructions are a little more complicated when the plunker is in embedded style.
Becomes critical as more (most?) plunkers are presented in embedded style See PR #2884
The old instructions looked mostly like this
This PR creates instructions that look like this
The text and image references are in
_includes/_set-addr-bar.jadewhich is imported in jade docs where needed except in the "Set Document Title" cookbook where the text changes and so the instructions must be pasted in.