This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(testing): simplify and accelerate path to Angular component testing #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
force-pushed
the
docs-testing-component-spec-plunker
branch
3 times, most recently
from
f681596 to
0f17762
Compare
wardbell
changed the title
wardbell
force-pushed
the
docs-testing-component-spec-plunker
branch
4 times, most recently
from
77ffdd7 to
44e4096
Compare
Foxandxss
reviewed
Nov 29, 2016
|
Review on dev server @900f724 via |
wardbell
force-pushed
the
docs-testing-component-spec-plunker
branch
3 times, most recently
from
9e61862 to
4fdf4b1
Compare
Rob Wormald recognized that we had no plunker for a simple component test. Added the banner-specs for that purpose and also a quickstart-specs in the setup folder Adjusted prose in testing and setup-systemjs-anatomy to call these out Supporting adjustments to plunker builder and gulpfile Test plunkers now open on a spec instead of on index.html
Moved external template spec earlier because it is likely to be needed right away. Now have plunkers for both inline and external template versions of `BannerComponent`
also comments on the optional "testing" folder and corrects var names to match also leaves Jasmine Spec Runner output visible when tests finish
wardbell
force-pushed
the
docs-testing-component-spec-plunker
branch
from
4fdf4b1 to
f5c372c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit
Rob Wormald recognized that we had no plunker for a simple component test.
Added the banner-specs for that purpose and also a quickstart-specs in the setup folder
Adjusted prose in testing and setup-systemjs-anatomy to call these out
Supporting adjustments to plunker builder and gulpfile
Test plunkers now open on a spec instead of on index.html
Second commit
Recognized that there was too much material getting in the way of learning to write Angular app tests.
Removed some stuff. Moved other stuff down.
Removed some of the "open on a spec" instructions because plunkers open in embedded-style
Third commit
Remove
karma-htmlfile-reporterfrom karma.conf and package.json because no longer used.Adjust a few other karma.conf settings.