This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh): Replaced window.history with location service #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
suggested changes
Sep 22, 2016
| @@ -38,7 +40,7 @@ export class HeroDetailComponent implements OnInit { | |||
|
|
|||
| // #docregion goBack | |||
| goBack(): void { | |||
| window.history.back(); | |||
| this.location.back(); | |||
| @@ -29,11 +31,11 @@ export class HeroDetailComponent implements OnInit { | |||
| // #docregion save | |||
| save(): void { | |||
| this.heroService.update(this.hero) | |||
| .then(this.goBack); | |||
| .then(() => this.goBack()); | |||
There was a problem hiding this comment.
Why this change? You are replacing a function g by an anonymous function which does nothing but call g. I.e., g and () => g() are equivalent, though the former is shorter.
There was a problem hiding this comment.
It throws an error of Cannot read property 'location' of nulll error when just providing the callback function when the e2e tests ran. I can use this.goBack.bind(this) instead of you think that would be cleaner.
There was a problem hiding this comment.
Oops, your change is actually the right thing to do to ensure that this gets bound properly in goBack.
chalin
approved these changes
Sep 22, 2016
| @@ -29,11 +31,11 @@ export class HeroDetailComponent implements OnInit { | |||
| // #docregion save | |||
| save(): void { | |||
| this.heroService.update(this.hero) | |||
| .then(this.goBack); | |||
| .then(() => this.goBack()); | |||
There was a problem hiding this comment.
Oops, your change is actually the right thing to do to ensure that this gets bound properly in goBack.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated references of "Component Router" to "Router"