Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

fix: boost transparency of sidenav #2427

Merged
merged 2 commits into from
Sep 22, 2016
Merged

fix: boost transparency of sidenav #2427

merged 2 commits into from
Sep 22, 2016

Conversation

ericjim
Copy link
Member

@ericjim ericjim commented Sep 21, 2016

Fixes: #2408

Preview

screen shot 2016-09-20 at 8 55 39 pm

cc @chalin

@alexwolfe
Copy link
Contributor

Believe it or not it will actually reduce the contrast ratio (since bg color will be a darker gray). So for accessibility, the color is better at .56.

Any specific reason to change it (preference is a valid option btw :) )

@ericjim
Copy link
Member Author

ericjim commented Sep 21, 2016

@alexwolfe The reason for change was to fix: #2408; not sure if you saw it. Though I get what you mean with the contrast ratio, it's really subtle.

Note that the problem is only visible when you are in a narrow resolution (mobile).

@alexwolfe
Copy link
Contributor

@ericjim Ahhh, good catch. Can you simply apply it to the mobiles styles? Otherwise I can do it today (will be tinkering around today anyway). Let me know.

@ericjim
Copy link
Member Author

ericjim commented Sep 21, 2016

@alexwolfe How's that?

@alexwolfe
Copy link
Contributor

@ericjim perfect 👍 Thanks for fixing this!

@alexwolfe alexwolfe merged commit c348e83 into angular:master Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants