This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(harp): use official pre-release 0.21 of harp #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Sep 16, 2016
| @@ -48,7 +48,7 @@ | |||
| "gulp-tslint": "^5.0.0", | |||
| "gulp-util": "^3.0.6", | |||
| "gulp-watch": "^4.3.4", | |||
| "harp": "git://github.com/filipesilva/harp.git#8da8d3497ddbfcbcbadd8be63e0fd731d7310cc4", | |||
| "harp": "^0.21.0-pre.0", | |||
There was a problem hiding this comment.
I believe it's pre.1 instead, see https://github.com/filipesilva/harp/commit/bf9030cb1ac2a6035bae3da9afbdab4990011370#commitcomment-19049717
I would also advise to not use the caret, semver resolution falls back to alphabetical on these non-semver ones.
There was a problem hiding this comment.
Yes, it is -pre.1.
semver resolution falls back to alphabetical
Good to know. Though, I wouldn't expect more than 9 pre subreleases.
filipesilva
approved these changes
Sep 16, 2016
|
Lgtm |
chalin
force-pushed
the
chalin-harp-version-0916
branch
from
078b376 to
33b6b6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@filipesilva's harp patch was just merged so we can start using the official pre-release again (as we had tried to do in #2301, but were forced to revert in #2308).
cc @naomiblack