This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: fix api docs issue on angular 2.0.0 #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
fix-2.0.0-build
branch
2 times, most recently
from
b7fc9a4 to
b077a15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our build-compile task fails against 2.0.0 because of an API docs building issue. It has since been fixed in angular/angular#11619 but not included in 2.0.0.
This PR allows our setup to use a SHA instead of a tag to specify the latest release we should test against, and sets the SHA to that of the PR that fixes our issue.
/cc @IgorMinar @naomiblack @chalin