This repository was archived by the owner on Dec 4, 2017. It is now read-only.
fix(footer): Footer logo is overflowing #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Footer logo was overflowing at ~960px wide viewport. Added `background-size: contain` (shorthand), and `max-width: 100%` to contain wrapper, and background image within grid.
LayZeeDK
changed the title
|
@LayZeeDK I've checked out this branch and compared before/after but don't see any difference. Can you include a screen shot of what exactly this is fixing using the current site vs. your branch? Thanks! |
|
Chrome 53 beta 64-bit before: Chrome 53 beta 64-bit after: Edge 13 before: Edge 13 after: |
wardbell
pushed a commit
to IdeaBlade/angular.io
that referenced
this pull request
Sep 23, 2016
fix(footer): Footer logo is overflowing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer logo was overflowing at ~960px wide viewport. Added
background-size: contain(shorthand), andmax-width: 100%to contain wrapper, and background image within grid.