This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Rc5 doc sweep #2218
Merged
Rc5 doc sweep #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed style for whitespace in imports. Removed + sign prefix for routing folders. Updated all code. Removed style that said to use lazy loading. There was no value in the style other than use it :)
|
Sounds good to me. Did you delete also the examples folders? (and routes...) |
|
I removed the folders for the examples (where there were ones). I also renamed the examples folders without the Of course, please check :) |
|
Weird, this only shows me that you deleted 03-05 (not 04-12 nor 04-15) |
|
hmmm. I don't see a 04-12 or 04-15 in the examples |
|
That is what you said in the first comment! :P |
|
Oh, we have styles without example, forgot :P |
|
@wardbell this is ready for you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 03-05, 04-12, 04-15. …
Removed style for whitespace in imports.
Removed + sign prefix for routing folders. Updated all code.
Removed style that said to use lazy loading. There was no value in the style other than use it :)