This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(lifecycle-hooks): post-RC5 Dart resync #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wardbell @Foxandxss @kwalrath : ready for review. I cleaned out trailing whitespace, so ignore whitespace for a better (re)viewing experience :). |
This was referenced Aug 18, 2016
chalin
force-pushed
the
chalin-dart-lifecycle-hooks-resync-0818
branch
from
f3f45fa to
3c419a6
Compare
| //- n/a for Dart | ||
| block other-angular-subsystems | ||
| :marked | ||
| The router, for instance, also has it's own [router lifecycle |
|
Aside from the one wording thing I noticed (which isn't a showstopper) LGTM. |
- TS prose: removed mention of `routerOnActivate` which no longer exists in the new router. - TS improvements to the sample code have also been propagated to the Dart sample. Contributes to angular#2077. E2E tests pass now.
chalin
force-pushed
the
chalin-dart-lifecycle-hooks-resync-0818
branch
from
eea17d7 to
fb6934a
Compare
|
Does @Foxandxss need to review this, or can I merge? |
|
Let me take a peek. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routerOnActivatewhich no longer exists in the new router.Contributes to #2077.
E2E tests for lifecycle-hooks pass now.