Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

fix(toh-5): Fixed issues in tutorial flow #2137

Closed
wants to merge 1 commit into from

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Aug 18, 2016

The HeroDetailComponent should be in the module declarations from the beginning.

Closes #2096, #2097, #2132

@brandonroberts
Copy link
Contributor Author

@wardbell @chalin please review

@chalin
Copy link
Contributor

chalin commented Aug 18, 2016

Yep, the HeroDetailComponent is missing from way back when it was introduced in toh-3. Maybe toh-4 needs to be checked too?

@@ -5,6 +5,7 @@ import { FormsModule } from '@angular/forms';

import { AppComponent } from './app.component';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Drop this blank line.

@chalin
Copy link
Contributor

chalin commented Aug 18, 2016

Minor tweaks suggested, along with the need for keeping a few lines for Dart. Other than that, it LGTM.

(Btw, the apparent problem with the tutorial flow was just a symptom; the root cause was because the starting state of the app.module.ts didn't match the end state of the previous chapter).

@brandonroberts
Copy link
Contributor Author

brandonroberts commented Aug 18, 2016

I made the suggested fixes and checked the toh-3 and toh-4 modules. The HeroDetailComponent was correctly included in those tutorials.

@brandonroberts
Copy link
Contributor Author

I also updated the app.module.ts for toh-6 for consistency


+ifDocsFor('dart')
.l-sub-section
:marked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Jade requires indentation levels to be in multiple of two characters, otherwise it can cause strange problems. Hence

  • Line 484 should be indented by 4 spaces (not 3)
  • Line 485 should be indented by 6 spaces (not 5).

@brandonroberts brandonroberts force-pushed the fix/toh5-issues branch 2 times, most recently from 8bd7e38 to 43d7c04 Compare August 18, 2016 17:14
@brandonroberts
Copy link
Contributor Author

Issues fixed

@chalin
Copy link
Contributor

chalin commented Aug 18, 2016

LGTM, if Travis is happy too.

The HeroDetailComponent should be in the module declarations from the beginning.
@wardbell
Copy link
Contributor

wardbell commented Aug 19, 2016

I hijacked your PR to also use InMemoryWebApiModule everywhere instead of the providers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants