-
Notifications
You must be signed in to change notification settings - Fork 875
fix(toh-5): Fixed issues in tutorial flow #2137
Conversation
c0b24aa
to
b122c04
Compare
Yep, the HeroDetailComponent is missing from way back when it was introduced in toh-3. Maybe toh-4 needs to be checked too? |
@@ -5,6 +5,7 @@ import { FormsModule } from '@angular/forms'; | |||
|
|||
import { AppComponent } from './app.component'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Drop this blank line.
Minor tweaks suggested, along with the need for keeping a few lines for Dart. Other than that, it LGTM. (Btw, the apparent problem with the tutorial flow was just a symptom; the root cause was because the starting state of the |
b122c04
to
d1ea894
Compare
I made the suggested fixes and checked the toh-3 and toh-4 modules. The |
d1ea894
to
5f52304
Compare
I also updated the |
|
||
+ifDocsFor('dart') | ||
.l-sub-section | ||
:marked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Jade requires indentation levels to be in multiple of two characters, otherwise it can cause strange problems. Hence
- Line 484 should be indented by 4 spaces (not 3)
- Line 485 should be indented by 6 spaces (not 5).
8bd7e38
to
43d7c04
Compare
Issues fixed |
LGTM, if Travis is happy too. |
The HeroDetailComponent should be in the module declarations from the beginning.
43d7c04
to
d862ffc
Compare
I hijacked your PR to also use |
The HeroDetailComponent should be in the module declarations from the beginning.
Closes #2096, #2097, #2132