This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(webpack): update testing for RC5 #2133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxandxss
force-pushed
the
webpack-rc5-tests
branch
from
75db343 to
6db52d8
Compare
Foxandxss
force-pushed
the
webpack-rc5-tests
branch
from
6db52d8 to
5597292
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the webpack unit test to use TestBed along with updates to the karma-shim.
Also I realized while doing it that I cannot disable all css on testing, so I modified the test config to just disable the application-wide styles which is what we should do.