This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(router): fix markdown, and example mixin cleanup #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed: markdown text not under `:marked` region (and so that text was not showing up in the generated html). - Fixed: code excerpt title `constructor` -> `isSelected`. - Cleanup of all makeExample mixin uses. This cleanup will help make it easier to record differences with the deprecated router chapter (which must have app-relative makeExample paths).
|
@brandonroberts : ready for review. |
chalin
changed the title
|
The first code example under |
|
Good catch. Fixed. |
Found another instance of markdown (a heading) outside of a `:marked` region.
chalin
force-pushed
the
chalin-ts-router-ex-mixin-cleanup-0812
branch
from
060bab8 to
25d277a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:markedregion (and so that text was not showing up in the generated html including the heading "Router Lifecycle Hooks").constructor->isSelected.Preliminary step to #2035: this cleanup will help make it easier to record differences with the deprecated router chapter (which must have app-relative makeExample paths).