This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: swap reflect on webpack to core-js #2042
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New reflect-metadata 0.1.4 broke webpack.
On the one hand, there is a dozen of warnings with this line:
const nodeCrypto = isNode && function () { try { return (void 0, require)("crypto"); } catch (e) { } }();
Also, reflect is stuck on an old Typescript and that fires hundred of errors (which broke our build).
So I am recommending that we swap
reflect-metadata
for the one insidecore-js
which works perfect.On the other hand I am investigating the warnings to see if they can be fix on webpack or reflect-metadata.