Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(dependency-injection): Clarify how TypeScript generates decorator metadata #1960

Closed
wants to merge 1 commit into from

Conversation

Igonato
Copy link
Contributor

@Igonato Igonato commented Jul 24, 2016

I think it's important to mention the compiler option. After reading the note I wanted to see how this magic works and what it looks like in a compiled javascript and tried to make a simple test in TypeScript playground. I got nothing and it took some time to figure out that a compiler option is involved in this.

…r metadata

I think it's important to mention the compiler option. I wanted to see how this magic works and what it looks like in a compiled javascript and tried to make a simple test in TypeScript playground. I got nothing and it took me some time to figure out that a compiler option is involved in this.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Igonato
Copy link
Contributor Author

Igonato commented Jul 24, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss
Copy link
Member

I like it.

@wardbell
Copy link
Contributor

Thank you. I agree. I took the liberty of further clarifying this point.

@wardbell wardbell closed this in fc1a9a6 Jul 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants