chore(install): reintroduce single install script #1900
Conversation
This single install script: - Checks for the proper version of node (some of us develop with node v4 on other sites, and it is too easy to forget to switch to v5 for angular.io). - Applies the patch (that is necessary to support harp compilation of Dart API pages).
|
@filipesilva @Foxandxss @wardbell @kwalrath : ready for review. Note that I have not touched the travis config. |
|
|
||
| cd `dirname $0`/.. | ||
|
|
||
| if [[ "$(node --version)" < "v5" ]]; then |
There was a problem hiding this comment.
Node 4 is a valid node. Well, there is a new change that made v4 unusable but we could fix that.
There was a problem hiding this comment.
Well, node v4 doesn't work for @kwalrath, and more often than not, forgetting to switch to v5 for Kathy has cause problems and results in wasted time.
Are you aware of anyone who must stick with node 4 and who is required to build ng.io docs? (Kathy has to do this every time she tests out a PR for merging :) If not, IMHO, we should just just drop v4.
There was a problem hiding this comment.
No, no one, but we were always striving to have node 4.x support, but I guess it is fine to not have it on this project.
|
lgtm. @chalin you mentioned something about the dart compilation, is it possible to run dart specific tasks via the CI at the moment? I tried to cover the ts/js ones I know of, but I don't know anything about the dart workflow for docs. |
Not at the moment. That is part of what I will be working on next. |
Our installation process can change rapidly. I think it helps if we have a single script to run that we ensure is up-to-date for all.
This PR reintroduces a single install script, which, in particular:
v4 on other sites, and it is too easy to forget to switch to v5 for
angular.io).
Dart API pages).