-
Notifications
You must be signed in to change notification settings - Fork 875
docs-styles(build): Operationalize doc styles build #1897
Conversation
eff427c
to
f0c560a
Compare
So from now own with ditch |
Yes, this will and should cater for all styling requirements. Should be able to use as little or as much as the example require. Once no examples depend on either bootstrap.css directly or styles.css anymore, both will be removed from the examples. |
421c0e6
to
9934e35
Compare
There's a race condition in which the gulp Fix that before proceeding with this PR Please note: this PR creates the new When we have confirmed that we like this new css file - a @naomiblack task - we'll need another PR (TBD) that propagates it to all doc samples by changing the generated filename from |
9934e35
to
9511ea8
Compare
See PR comment: angular#1897 (comment) DO NOT KEEP THIS COMMIT
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
I fixed the race condition by sending a The problem is that we would like to have the new a2docs.css in e2e tests. We were never "waiting" for So as soon as you double check that the race condition is gone (and remove the I could present that alternative solution in a different PR to not clutter this one. |
6bec2b6
to
ac675d4
Compare
Thank you, @AlmeroSteyn ! And @Foxandxss for taking it the last mile. |
Automated process to build a
CSS
file for the Angular 2 documentation examples.The process is driven by using the
LESS
source from Bootstrap CSS. By overriding theLESS
variables and including other style overrides in theLESS
build a single stylesheet is created that provides the Design approved example styles.It is integrated in the
gulp
add-example-boilerplate and the _copy-example-boilerplate tasks.Remaining steps (after merging to master):
a2docs.css
tosample.css
which will propagate the style change to all doc samples.