This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(router): Removed references to deprecated router #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
force-pushed
the
chore/router-docs-sweep
branch
from
115de96 to
a12d9fb
Compare
|
I like what I see Brandon. You need to rebase because the style-guide change is already in master (I did it personally because I created that example). The only remaining thing is the upgrade guide that I will tackle myself too. |
brandonroberts
force-pushed
the
chore/router-docs-sweep
branch
from
a12d9fb to
484c267
Compare
|
I've rebased against latest. I had a failed build due to animations but not related to my changes |
|
Animation is a different issue. I will fix it separately. |
brandonroberts
force-pushed
the
chore/router-docs-sweep
branch
4 times, most recently
from
7511393 to
83c71d2
Compare
brandonroberts
changed the title
|
This one is ready @Foxandxss . It removes all references to the deprecated router with the exception of testing and ngUpgrade. |
brandonroberts
force-pushed
the
chore/router-docs-sweep
branch
from
83c71d2 to
079747a
Compare
|
Also renames the constant variables to lowerCamelCase (as it should). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.