Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore: dgeni tag definitions for ts2dart tags #1833

Closed

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 5, 2016

New dgeni tag definitions for ts2dart tags which are currently causing spurious warnings when generating API docs.

@chalin
Copy link
Contributor Author

chalin commented Jul 5, 2016

@Foxandxss @wardbell @kwalrath : ready for review.

@chalin chalin changed the title chore: dgeni tag defintions for ts2dart tags chore: dgeni tag definitions for ts2dart tags Jul 5, 2016
@chalin chalin force-pushed the chalin-api-ignore-ts2dart-anno-0705 branch from 724c094 to 4c707c3 Compare July 6, 2016 11:36
@@ -0,0 +1,4 @@
// A ts2dart compiler annotation that can be ignored in API docs.
module.exports = function() {
return { name: 'Annotation' };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that, in addition you can also add an ignore flag:

{ name: 'Annotation', ignore: true };

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petebacondarwin
Copy link
Contributor

Apart from additional ignore flag, this LGTM

@chalin chalin force-pushed the chalin-api-ignore-ts2dart-anno-0705 branch from 4c707c3 to 510aae5 Compare July 7, 2016 10:57
New `dgeni` tag definitions for `ts2dart` tags which are currently
causing spurious warnings when generating API docs.
@chalin chalin force-pushed the chalin-api-ignore-ts2dart-anno-0705 branch from 510aae5 to faeb57e Compare July 8, 2016 04:58
petebacondarwin pushed a commit to petebacondarwin/angular.io that referenced this pull request Jul 8, 2016
New `dgeni` tag definitions for `ts2dart` tags which are currently
causing spurious warnings when generating API docs.

Closes angular#1833
petebacondarwin pushed a commit to petebacondarwin/angular.io that referenced this pull request Jul 8, 2016
New `dgeni` tag definitions for `ts2dart` tags which are currently
causing spurious warnings when generating API docs.

Closes angular#1833
@wardbell
Copy link
Contributor

Merging on basis of @chalin and @petebacondarwin good credit ;-)

@wardbell wardbell closed this in 86f8212 Jul 12, 2016
@chalin chalin deleted the chalin-api-ignore-ts2dart-anno-0705 branch July 12, 2016 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants