This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: tslint sweep done #1654
Merged
chore: tslint sweep done #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 28, 2016
- Updated Dart code to match TS. - Ran dartfmt. - Enabled e2e tests; suites passed: - public/docs/_examples/attribute-directives/dart - public/docs/_examples/attribute-directives/ts - Prose copyedits.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following angular#1654. dependency-injection: - Renamed components in providers_component.dart - E2e suites passed: - public/docs/_examples/dependency-injection/dart - public/docs/_examples/dependency-injection/ts template-syntax: - Removed unused global variable. - Suites passed: public/docs/_examples/template-syntax/dart public/docs/_examples/template-syntax/ts toh-2 & 3: - Clean-up.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following angular#1654: - Updates to follow style guide - Enabled e2e tests - Fixes to ensure tests pass: in after_view_component.dart and after_content_component.dart - Changed test over comment field in template to be: *ngIf="comment.isNotEmpty" - Suites passed: public/docs/_examples/lifecycle-hooks/dart public/docs/_examples/lifecycle-hooks/ts
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following angular#1654: - Updates to follow style guide - Suites passed: public/docs/_examples/pipes/dart - Suites failed (known issue - angular#1761): public/docs/_examples/pipes/ts
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following angular#1654: - Updates to follow style guide - Suites passed: public/docs/_examples/user-input/dart public/docs/_examples/user-input/ts Note: the click-me2 component is not mentioned in the prose, maybe it should be.
kwalrath
pushed a commit
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following #1654. dependency-injection: - Renamed components in providers_component.dart - E2e suites passed: - public/docs/_examples/dependency-injection/dart - public/docs/_examples/dependency-injection/ts template-syntax: - Removed unused global variable. - Suites passed: public/docs/_examples/template-syntax/dart public/docs/_examples/template-syntax/ts toh-2 & 3: - Clean-up.
kwalrath
pushed a commit
that referenced
this pull request
Jun 28, 2016
kwalrath
pushed a commit
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following #1654: - Updates to follow style guide - Suites passed: public/docs/_examples/user-input/dart public/docs/_examples/user-input/ts Note: the click-me2 component is not mentioned in the prose, maybe it should be.
kwalrath
pushed a commit
that referenced
this pull request
Jun 28, 2016
Mainly Dart-side review, following #1654: - Updates to follow style guide - Enabled e2e tests - Fixes to ensure tests pass: in after_view_component.dart and after_content_component.dart - Changed test over comment field in template to be: *ngIf="comment.isNotEmpty" - Suites passed: public/docs/_examples/lifecycle-hooks/dart public/docs/_examples/lifecycle-hooks/ts
kwalrath
pushed a commit
that referenced
this pull request
Jun 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here it is, 0 lint errors.
I deleted two files along the way (there are probably more) that are not used and complained about lints. Fire to them.
I started moving variables before constructors and stuff (member-ordering) when I could do it (not breaking any docregion) but then I realized that we have a lot of those, a lot we can't move so I removed the rule. Doesn't make sense for this project.
The "biggest" change is probably adding prefixes to the selectors of
cb-dependency-injection. It is an example, but I prefer if all our examples shows good practices.@chalin will need to make the appropriate changes at Dart when this gets merged.