Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore(ignored/boilerplate files): minor cleanup #1646

Closed

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 10, 2016

(1) We are ignoring all style files including the master styles.css:

> cd .../_examples
> git ls-files --ignored --exclude-standard | grep 'styles*.css'
styles.css

We don't want to do that. Now we only ignore styles.css in subdirectories. Cf. #894.

(2) The gulp target copy-example-boilerplate is also copying ts boilerplate into dart folders. This is fixed.

(3) Boilerplate files are now chmod -w so as to avoid that they be edited by mistake. Both of the following have been tested after these changes and continue to work as expected:

gulp add-example-boilerplate
gulp remove-example-boilerplate

(4) Entries in public/docs/_examples/.gitignore corresponding to boilerplate files have been moved to the top.

(5) Duplicate entries in public/docs/_examples/.gitignore relative to the top-level .gitignore have been removed.

(6) Entries in public/docs/_examples/.gitignore that are global in nature have been moved to the top-level .gitignore.

@chalin chalin force-pushed the chalin-chore-ingored-files-cleanup-0610 branch from ef38e66 to e8c7116 Compare June 13, 2016 14:14
@chalin chalin force-pushed the chalin-chore-ingored-files-cleanup-0610 branch from e8c7116 to 92d9ce8 Compare June 13, 2016 17:21
@wardbell
Copy link
Contributor

LGTM. I am merging it

I'm prepared to see how life is with

Boilerplate files are now chmod -w

Sometimes I alter them for local purposes. But I see that could be a source of error. We can always roll this particular change back if it proves too onerous.

@wardbell wardbell closed this in 5adbfb9 Jun 13, 2016
@chalin
Copy link
Contributor Author

chalin commented Jun 13, 2016

Btw, chmod -w doesn't prevent us from editing the files (I sometimes make local edits to); most modern editors/IDEs like Emacs and VSCode will warn the developer "This file is read-only, do you still want to save your changes?" and save changes to a read-only file if that is what the developer wants.

@chalin chalin deleted the chalin-chore-ingored-files-cleanup-0610 branch June 13, 2016 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants