This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-4/ts): copyedits #1638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-toh-4-ts-minor-edits-0609
branch
from
f9aa2c3 to
59dc124
Compare
chalin
force-pushed
the
chalin-toh-4-ts-minor-edits-0609
branch
from
59dc124 to
9c8a4ff
Compare
| // #enddocregion get-heroes | ||
| // #enddocregion just-get-heroes | ||
| // #enddocregion get-heroes, just-get-heroes | ||
| // #enddocregion |
There was a problem hiding this comment.
Shouldn't this one disappear?
There was a problem hiding this comment.
I've always assumed that we could not specify the unnamed docregion when other docregions are being named. But I could be wrong (I'll test that out some time).
There was a problem hiding this comment.
Had a conversation with @Foxandxss in a separate thread, and he is ok with the change made here. FYI.
|
LGTM. I don't know about @Foxandxss question but if we messed up, we can fix it. |
|
No, it would not mess anything up. I think that Jesus was commenting about a potentially unnecessary extra line (i.e., have two |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #1628.