This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-3/dart): copyedits and new snake_case glossary entry #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2016
Closed
chalin
force-pushed
the
chalin-toh-3-dart-minor-edits-0608
branch
2 times, most recently
from
683e761 to
30ca053
Compare
chalin
force-pushed
the
chalin-toh-3-dart-minor-edits-0608
branch
from
30ca053 to
b445fce
Compare
|
What is the state of this? It is difficult for me to review when there is a mix of Dart and TS changes. The TS changes LGTM. Maybe it is better if Kathy merges this one. |
chalin
force-pushed
the
chalin-toh-3-dart-minor-edits-0608
branch
from
b445fce to
13cebac
Compare
Copyedits made to glossary as well. Note that "Scoped Package" has been removed from the Dart glossary.
chalin
force-pushed
the
chalin-toh-3-dart-minor-edits-0608
branch
from
13cebac to
df54a19
Compare
|
Taking a look now... |
|
LGTM. Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #1628.