This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-pt5): change getHero to match toh-pt6 getHero #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. I agree. Slight wording change. Merging. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a discrepancy between the
getHerofunctions in the Tour of Heroes tutorial part 6 and 7.Part 6 getHero: https://github.com/angular/angular.io/blob/master/public/docs/_examples/toh-5/ts/app/hero.service.ts#L21
Part 7 getHero: https://github.com/angular/angular.io/blob/master/public/docs/_examples/toh-6/ts/app/hero.service.ts#L34
Reasoning: part 7 advises the reader to remove the mock
HEROESdata but does not tell the reader to updategetHeroaccordingly, resulting in an error. Rather than requiring the reader to rewritegetHeroto usegetHeroesin part 7, it seems to make more sense to have them write it this way from the start.