This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(_util-fns): generalize makeExample, drop makeProjExample #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wardbell, @Foxandxss et al.: keeping things simple and dropping the recently introduced FYI, I performed a diff of the generated site ( cc: @kwalrath
diff -r -x cheatsheet.json www/docs/dart/latest/quickstart.html 20160524/www/docs/dart/latest/quickstart.html
263c263
< <div class="example-title">web/web/styles.css (excerpt)</div><code-example language="css" format="">h1 {
---
> <div class="example-title">web/styles.css (excerpt)</div><code-example language="css" format="">h1 { |
chalin
force-pushed
the
chalin-chore-make-example-0524
branch
6 times, most recently
from
1a29503 to
c06ca55
Compare
| @@ -28,7 +28,7 @@ mixin liveExampleLink2(linkText, exampleUrlPartName) | |||
| - var href = 'http://github.com/angular-examples/' + ex; | |||
| span #[+liveExampleLink(linkText, ex)] (#[a(href='#{href}' target="_blank") #{srcText}]) | |||
|
|
|||
| - var adjustExamplePath = function(_path) { | |||
| - var adjustTsExamplePath4Dart = function(_path) { | |||
|
Minor comments, but looks good to me! |
|
@thso : done - either fixed issue or responded with feedback. |
chalin
force-pushed
the
chalin-chore-make-example-0524
branch
3 times, most recently
from
1ac7776 to
a0b5efa
Compare
Preparation for further refactorings.
`makeExample` can now work with both doc folder relative and project relative paths.
chalin
force-pushed
the
chalin-chore-make-example-0524
branch
from
a0b5efa to
8b16ded
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeExamplecan now work with both doc folder relative and project relative paths.