This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(style-guide): push main.ts to src folder #1390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. Has CLI adjusted too? |
|
CLI was always having main.ts in About the barrel, they export more than one thing, so that is fine for now I guess. |
|
LGTM |
|
The move is OK with me. As @Foxandxss says, I am intolerant of a barrel at the root with only |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @johnpapa @wardbell @Brocco @mgechev
We agreed on pushing
main.tsto the src folder so here it is. We also talked about adding a barrel in/src/app/with a single export, but that is a no-no for @wardbell.So with this PR and Ward's opinion, we can close the next issue:
Closes #1361