This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dev guide): structural-directives - ts minor edits, dart first version #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
changed the title
|
Ready for review and merge. |
chalin
changed the title
| @@ -163,7 +166,7 @@ figure.image-display | |||
| We can confirm these effects by wrapping the middle "hip" of the phrase "Hip! Hip! Hooray!" within a `<template>` tag. | |||
| +makeExample('structural-directives/ts/app/structural-directives.component.html', 'template-tag')(format=".") | |||
| :marked | |||
| The display is a 'Hip!' short of perfect enthusiasm. The DOM effects are different when Angular is control. | |||
| The display is a 'Hip! Hooray!', short of perfect enthusiasm. The DOM effects are different when Angular is control. | |||
There was a problem hiding this comment.
Think there is an issue with end of the sentence. Do we mean: 'when Angular IS in control'?
|
Reviewing this now. |
|
LGTM |
…ersiondocs(dev guide): structural-directives - ts minor edits, dart first version - copyedits and other minor edits for TS - a first version of the chapter for Dart
chalin
force-pushed
the
chalin-guide-struct-dir-0503
branch
from
f1000f3 to
1b2454a
Compare
chalin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.