[WIP] docs(style-guide): add style-guide - v.4 #1180
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
googlebot: John agrees to this commit |
| bootstrap(AppComponent, []); | ||
|
|
||
| const HEROES: Hero[] = [ | ||
| {id: 1, name: 'Bombasto'}, |
There was a problem hiding this comment.
3 char indentation looks weird. Is there some rule for this? Do you use some auto-formatting tool in TS?
There was a problem hiding this comment.
Nice catch. There will be a linter on these that @mgechev is adding. It will catch stuff like this.
There was a problem hiding this comment.
@Foxandxss Can you fix this kitchen-sink to 2 char spacing?
There was a problem hiding this comment.
Sure, I will push a new commit to this branch in a bit.
wardbell
force-pushed
the
docs-style-guide-4
branch
from
ceda1c9 to
d2f99c8
Compare
| export const HEROES: Hero[] = [ | ||
| {id: 1, name: 'Bombasto'}, | ||
| {id: 2, name: 'Tornado'}, | ||
| {id: 3, name: 'Magneta'}, |
There was a problem hiding this comment.
Please dont worry about these for now. @Foxandxss will catch these once we have @mgechev 's linter in there. Or he can just use an .editorconfig to make sure they are all 2 chars
|
We have a duplicated 05-15. Lets promote |
|
We have a 08-03 after the 05-XX and before the 07-XX so I suggest renaming it to 06-XX (01 I guess). |
wardbell
force-pushed
the
docs-style-guide-4
branch
3 times, most recently
from
bebcc76 to
17071a9
Compare
wardbell
force-pushed
the
docs-style-guide-4
branch
from
c922a11 to
d5e909b
Compare
Work in progress DO NOT MERGE
continuation of PR #1170