Skip to content

fix(@angular/ssr): disable component boostrapping when running route extraction #29183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions packages/angular/ssr/src/routes/ng-routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@

import { APP_BASE_HREF, PlatformLocation } from '@angular/common';
import {
APP_INITIALIZER,
ApplicationRef,
Compiler,
ComponentRef,
Injector,
inject,
runInInjectionContext,
ɵConsole,
ɵENABLE_ROOT_COMPONENT_BOOTSTRAP,
} from '@angular/core';
import { INITIAL_CONFIG, platformServer } from '@angular/platform-server';
import {
Expand Down Expand Up @@ -493,16 +491,8 @@ export async function getRoutesFromAngularRouterConfig(
useFactory: () => new Console(),
},
{
// We cannot replace `ApplicationRef` with a different provider here due to the dependency injection (DI) hierarchy.
// This code is running at the platform level, where `ApplicationRef` is provided in the root injector.
// As a result, any attempt to replace it will cause the root provider to override the platform provider.
// TODO(alanagius): investigate exporting the app config directly which would help with: https://github.com/angular/angular/issues/59144
provide: APP_INITIALIZER,
multi: true,
useFactory: () => () => {
const appRef = inject(ApplicationRef);
appRef.bootstrap = () => undefined as unknown as ComponentRef<unknown>;
},
provide: ɵENABLE_ROOT_COMPONENT_BOOTSTRAP,
useValue: false,
},
]);

Expand Down
Loading