Skip to content

fix(@angular/build): prevent transformation of Node.js internal dependencies by Vite #28393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit excludes Node.js module imports from being processed by Vite when prebundling is enabled.

Closes #28390

…dencies by Vite

This commit excludes Node.js module imports from being processed by Vite when prebundling is enabled.

Closes angular#28390
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 11, 2024
@alan-agius4 alan-agius4 requested a review from clydin September 11, 2024 12:05
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 11, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 11, 2024
@alan-agius4 alan-agius4 merged commit 4153a6e into angular:main Sep 11, 2024
32 of 33 checks passed
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 18.2.x

@alan-agius4 alan-agius4 deleted the exclude-node-js branch September 11, 2024 13:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error after upgrading from 18.0.6 to 18.2.3
2 participants