Skip to content

fix(@angular/build): correctly name entry points to match budgets #27947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: #27936

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 27, 2024
@alan-agius4 alan-agius4 requested a review from clydin June 27, 2024 09:19
@alan-agius4 alan-agius4 changed the title fix(@angular/build): correctly name entry points to match budget constraints fix(@angular/build): correctly name entry points to match budgets Jun 27, 2024
@alan-agius4 alan-agius4 force-pushed the entry-name-budgets branch 2 times, most recently from dc8a472 to e07cbeb Compare June 27, 2024 09:50
This commit addresses an issue where some lazy entry points were not name correctly to align with specified budgets.

Closes: angular#27936
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 27, 2024
@alan-agius4 alan-agius4 merged commit f3ba208 into angular:main Jun 27, 2024
30 checks passed
@alan-agius4 alan-agius4 deleted the entry-name-budgets branch June 27, 2024 11:45
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 18.0.x, 18.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular.json budgets not finding the created bundles
2 participants