Skip to content

fix(@angular-devkit/build-angular): allow mts and cts file replac… #27125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

demurgos
Copy link
Contributor

…ement

Updates the fileReplacement pattern to allow .mts and .cts files. This enables support for TypeScript files with explicit ESM support.

Closes #27124

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Replacing cts, ctsx, mts, mtsx files is rejected by schema validation while these files are supported by the build script.

Issue Number: #27124

What is the new behavior?

.cts and .mts files are allowed to be replaced.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
LGTM.

The test failure is unrelated to this change.

@clydin clydin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Feb 20, 2024
…ement

Updates the `fileReplacement` pattern to allow `.mts` and `.cts` files.
This enables support for TypeScript files with explicit ESM support.

Closes angular#27124
@dgp1130 dgp1130 merged commit fa146b8 into angular:main Feb 21, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema validation fails when replacing .mts file with another one
3 participants