Skip to content

fix(@angular/cli): prevent BOM errors in package.json during ng update #27062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

alan-agius4
Copy link
Collaborator

To prevent JSON.parse errors triggered by Byte Order Marks (BOMs) in package.json files, the readJson tree method is now utilized for more reliable BOM handling.

Closes #27052

@alan-agius4 alan-agius4 requested a review from clydin February 9, 2024 08:27
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 9, 2024
…date`

To prevent `JSON.parse` errors triggered by Byte Order Marks (BOMs) in package.json files, the `readJson` tree method is now utilized for more reliable BOM handling.

Closes angular#27052
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 9, 2024
@alan-agius4 alan-agius4 merged commit 782c718 into angular:main Feb 9, 2024
@alan-agius4 alan-agius4 deleted the update-bom-cli branch February 9, 2024 14:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng update - Migration failed: Unexpected token '', "{ "nam"... is not valid JSON
2 participants