fix(@angular-devkit/build-angular): ensure correct .html served with Vite dev-server
#27049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: minor
alan-agius4
changed the title
index.html served with Vite dev-server.html served with Vite dev-server
…h Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes angular#27044
alan-agius4
force-pushed
the
html-fallbacking-vite
branch
from
649baa7 to
5047270
Compare
alan-agius4
added
the
action: review
clydin
approved these changes
Feb 7, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an
index.htmlexisted as an asset under a specific path, the generatedindex.htmlwould be served instead.This fix addresses the issue, ensuring that the appropriate
.htmlis served when using the Vite dev-server.Closes #27044