Skip to content

fix(@angular-devkit/build-angular): add required modules as externals imports #26956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

alan-agius4
Copy link
Collaborator

Prior to this change any module which was used using require was not listed as an external.

Closes #26833

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 25, 2024
@alan-agius4 alan-agius4 requested a review from clydin January 25, 2024 08:51
…ls imports

Prior to this change any module which was used using `require` was not listed as an external.

Closes angular#26833
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): correctly add required modules as externals fix(@angular-devkit/build-angular): add required modules as externals imports Jan 25, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 25, 2024
@alan-agius4 alan-agius4 merged commit d6aea27 into angular:main Jan 25, 2024
@alan-agius4 alan-agius4 deleted the external-require branch January 25, 2024 14:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic require of "google-protobuf" is not supported
2 participants