fix(@angular-devkit/build-angular): deleteOutputPath when using esbuild-builder
#26313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
esbuild-delete-output
branch
from
1db122f to
adc0db2
Compare
JoostK
reviewed
Nov 10, 2023
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
esbuild-delete-output
branch
4 times, most recently
from
9f5150e to
91bb1c6
Compare
clydin
approved these changes
Nov 12, 2023
...gular_devkit/build_angular/src/builders/application/tests/options/delete-output-path_spec.ts
Outdated
Show resolved
Hide resolved
...r_devkit/build_angular/src/builders/browser-esbuild/tests/options/delete-output-path_spec.ts
Outdated
Show resolved
Hide resolved
…build-builder` Prior to this change the `deleteOutputPath` was not being used in the esbuild-builder. Closes angular#26308
…use FS promise APIs As per commit title.
alan-agius4
force-pushed
the
esbuild-delete-output
branch
from
91bb1c6 to
9890ca8
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the
deleteOutputPathwas not being used in the esbuild-builder.Closes #26308