fix(@angular-devkit/build-angular): correctly resolve polyfills when baseUrl URL is not set to root
#25959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
polyfills-resolve
branch
from
a53b433 to
45507fe
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
polyfills-resolve
branch
from
45507fe to
69e63ec
Compare
…`baseUrl` URL is not set to root Prior to this change when `baseUrl` was set to non-root or not set polyfills were not correctly resolved. Internally Esbuild uses the `baseUrl` to resolve non relative imports. Closes: angular#25341
alan-agius4
force-pushed
the
polyfills-resolve
branch
from
69e63ec to
1640c25
Compare
clydin
approved these changes
Oct 5, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change when
baseUrlwas set to non-root or not set polyfills were not correctly resolved. Internally Esbuild uses thebaseUrlto resolve non relative imports.Closes: #25341