perf(@angular-devkit/build-angular): reduce rebuilt times when using the scripts option
#24715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
changed the title
scripts optionscripts option
…the `scripts` option In some cases, using the `scripts` option caused a lot of `DescriptionFileUtils.loadDescriptionFile` calls which caused a bottleneck during build times. The why to this is still unknown, but a workaround is to use the resolver from the Webpack compilation instead of the compiler. Closes angular#24634
alan-agius4
force-pushed
the
resolver-scripts
branch
from
bbd221c to
140abe7
Compare
clydin
approved these changes
Feb 14, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, using the
scriptsoption caused a lot ofDescriptionFileUtils.loadDescriptionFilecalls which caused a bottleneck during build times.The why to this is still unknown, but a workaround is to use the resolver from the Webpack compilation instead of the compiler.
Closes #24634
From @fearghalom