fix(@angular/cli): register schematic aliases when providing collection name in ng generate
#24542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
alan-agius4
force-pushed
the
schematic-aliases
branch
2 times, most recently
from
36d712e to
16197a0
Compare
alan-agius4
force-pushed
the
schematic-aliases
branch
from
16197a0 to
6adc867
Compare
alan-agius4
changed the title
ng generate.ng generate
alan-agius4
added
state: WIP
and removed
action: review
…on name in `ng generate` Previously, schematic aliases were not registered when a collection name was provided to `ng generate`. Example: `ng generate c` where `c` is an alias for `component` would work, but `ng generate @schematics/angular:c` would fail. This commits fixes the schematic registration to handle the latter case. Closes angular#24518
alan-agius4
force-pushed
the
schematic-aliases
branch
from
6adc867 to
0f9172e
Compare
clydin
approved these changes
Jan 13, 2023
alan-agius4
added
action: merge
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, schematic aliases were not registered when a collection name was provided to
ng generate. Example:ng generate cwherecis an alias forcomponentwould work, butng generate @schematics/angular:cwould fail. This commits fixes the schematic registration to handle the latter case.Closes #24518